Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prequisities for anagram practice exercise #1548

Merged

Conversation

AnishDe12020
Copy link
Contributor

I have added the prerequisites for the anagram practice exercise. I am opening this pull request only for this exercise and as per how it goes I will decide on how many exercises I should add per pull request from next time.

References #984

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Dear AnishDe12020

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

config.json Outdated Show resolved Hide resolved
@junedev
Copy link
Member

junedev commented Dec 8, 2021

@AnishDe12020 The CI checks complain about the formatting. Here you can find out how to format the content correctly: https://github.com/exercism/javascript/blob/main/CONTRIBUTING.md#format

@AnishDe12020
Copy link
Contributor Author

@AnishDe12020 The CI checks complain about the formatting. Here you can find out how to format the content correctly: https://github.com/exercism/javascript/blob/main/CONTRIBUTING.md#format

Ya sure, I have run the script to format. Just one recommendation, running prettier can be added as a script to package.json so that it can easily be run with a comment like npm run format.

@junedev junedev added the x:size/small Small amount of work label Dec 9, 2021
@junedev junedev merged commit c0dd52a into exercism:main Dec 9, 2021
@AnishDe12020 AnishDe12020 deleted the practice-exercises-prequisities-anagram branch December 9, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants