Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'input' field #2766

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

Caesarovich
Copy link
Contributor

The input field is unused and causes a linter warning, which might be confusing for someone doing this exercise.

Screenshot from 2024-03-06 18-24-03

The input field is unused and causes a linter warning, which might be confusing for someone doing this exercise.
Copy link
Contributor

github-actions bot commented Mar 6, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 6, 2024
@Caesarovich Caesarovich changed the title Remove unused 'input' field [no important files changed] Remove unused 'input' field Mar 6, 2024
@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Mar 11, 2024
@andrerfcsantos andrerfcsantos changed the title [no important files changed] Remove unused 'input' field Remove unused 'input' field Mar 11, 2024
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make this change in the gen.go file?

@Caesarovich
Copy link
Contributor Author

Hi, thanks for replying.

I did not notice this .meta folder at first, my bad.
I am not quite sure to understand yet how it works, please let me know if my latest commit contains errors.

@Caesarovich
Copy link
Contributor Author

Any follow up @andrerfcsantos ?

Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review this. This looks good!

@andrerfcsantos
Copy link
Member

Closing and reopening to force CI to run.

@andrerfcsantos
Copy link
Member

@Caesarovich I don't like to mess with other people's branches, but in the interest of merging this, I merged main from upstream into your branch. I also made an extra commit fixing a formatting warning in gen.go.

Thanks for this!

@andrerfcsantos andrerfcsantos merged commit aede71e into exercism:main Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants