Use global coordinates when computing tabs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is allows shapes to come from multiple different bodies/parts by transforming them all into the global coordinate system before performing interlock computations.
TODO: this should be fleshed out more if we end up actually wanting it
sapphire-arches
force-pushed
the
bt/use-global-coords
branch
from
68f761e
to
f0c0c23
Compare
|
Hello, |
execuc
force-pushed
the
master
branch
2 times, most recently
from
16491af
to
c304813
Compare
|
@bobtwinkles please follow up |
|
To summarize; it doesn't work, but contains some steps in the right direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the computation of tabs take place in global coordinate space, so things don't break in weird ways when working with shapes from different bodies/parts. This probably needs additional testing/refinement before being merged.