Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest certain changes to weight computations for p2p phase (specifically init_reg_body function inside fmm.cpp).
Currently, We iterate over all the bodies to see if each body influences some cells. This is an exhaustive way of doing that.
I now pick a target cell and just see the bodies in its neighbouring cells if they have some influence on the target cell. This avoids looking into all leaf cells, which slows down computation particularly as the number of particles grows.
Also, I consider only those bodies for regularization which doesn't have weight one in their own cell.
I have tried a few experiments with this update on my workstation:
./test_reg -n 33876 -P 6 -m 16 -a fd -r 0.01
init_reg_body
time is reduced from0.47098
to0.00800
seconds./test/test_reg -n 120000 -P 6 -m 16 -a fd -r 0.01
init_reg_body
time is reduced from12.26815
to0.05770
seconds