EEI: Improved docs for getAddress() #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jul 9, 2018
eth_interface.md
Outdated
| @@ -31,12 +31,18 @@ Subtracts an amount to the gas counter | |||
|
|
|||
| ## getAddress | |||
|
|
|||
| Gets address of currently executing account and loads it into memory at | |||
| the given offset. | |||
| ```wast | |||
There was a problem hiding this comment.
I though that providing a wast function declaration would look nice.
There was a problem hiding this comment.
is i32ptr a valid alias of i32 in wast?
There was a problem hiding this comment.
No. It's only the alias here for easier reading.
|
I think it looks good except the wast code. Probably the rest of the spec uses the other wording too which could be updated. |
|
Thanks for handling this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative 1
Pass the contract address in the first memory page. We would have to specify that the
thisaddress is in at index0,calleraddress at index32,valueat index64, ...