Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect (?) flip=True within plot_file() and plot_lines() #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

doersino
Copy link

@doersino doersino commented May 2, 2020

When

  1. plotting a file via plot_file() or
  2. a set of lines via plot_lines(),

my drawings come out flipped along the x-axis. Taking a look at the code, I noticed that

  1. plot_file() calls plot_lines() with flip=True, which seems wrong but the removal of which didn't fix my problems on its own, and
  2. plot_lines() calls rotate_and_scale_lines() with flip=True. Instead supplying flip=flip, in conjunction with the previous point, fixes both of my problems.

According to git blame, these two occurrences of flip=True have been present for quite a while. Given this and the lack of issues or pull requests relating to the problems I encountered, I'm not sure if this is actually wrong or if something on my side is set up incorrectly.

@doersino
Copy link
Author

doersino commented May 3, 2020

Plus, I think that

if flip ^ rotate:

in rotate_and_scale_lines() must be replaced with just

if flip:

but the same caveats as above apply. Maybe it's just something with my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant