Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deno fmt #33

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

nakasyou
Copy link
Collaborator

Description

In deno task format, biome calls after deno fmt calls. So codes formatted by deno are overrides. by biome. Therefore deno fmt is meaningless and you should remove it because it makes performance bottleneck.

Checklist

  • Run tests (optional)
  • Add jsdoc (optional)
  • Test in your environment (optional)

If you feel good :), please do the contents of the checklist.

@EdamAme-x
Copy link
Member

I did so because biome had a rule that was ignored, but it doesn't seem to be necessary anymore.

@EdamAme-x EdamAme-x merged commit 51c5a4a into evex-dev:main Sep 13, 2024
2 checks passed
@nakasyou nakasyou deleted the chore/remove-deno-fmt branch September 14, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants