Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squad Create form adds old type filters #674

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

moppa
Copy link
Contributor

@moppa moppa commented Apr 4, 2024

Only the Edit blade had been updated to use the new filter system. So if you added filters when you create your squad then the squad would not populate and related jobs that trigger the different squad observers failed.

@recursivetree
Copy link
Contributor

Something something I think I just forgot that when fixing the CVE originally :)
Anyways, I recommend that this should get merged.

The only thing I'm not sure about is whether it wouldn't be better to have one variable with the available filters instead of duplicating the same thing across multiple files. It might help with mistakes like this in the future.

@Crypta-Eve Crypta-Eve merged commit 43f8217 into eveseat:5.0.x Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants