Skip to content

Commit

Permalink
update new plugin name
Browse files Browse the repository at this point in the history
Signed-off-by: Bryce Palmer <[email protected]>
  • Loading branch information
everettraven committed Sep 12, 2023
1 parent 16f8556 commit 72da0c8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions changelog/fragments/ansiblev2alpha.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# release notes and/or the migration guide
entries:
- description: >
Adds a new `ansible/v2-alpha` plugin. The only user facing difference is that the
Adds a new `ansible-external/v1-alpha` plugin. The only user facing difference is that the
image used in the scaffolded `Dockerfile` `FROM` directive is now
`quay.io/operator-framework/ansible-operator-plugins:<version>`. The first version
tag that is usable is `v0.1.2`.
Expand Down Expand Up @@ -31,7 +31,7 @@ entries:
# Migration can be defined to automatically add a section to
# the migration guide. This is required for breaking changes.
migration:
header: (Optional) Converting from `ansible/v1` to `ansible/v2-alpha`
header: (Optional) Converting from `ansible/v1` to `ansible-external/v1-alpha`
body: |
In your `Dockerfile`, replace the `FROM` directive of:
```
Expand Down
5 changes: 4 additions & 1 deletion internal/cmd/operator-sdk/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ func GetPluginsCLIAndRoot() (*cli.CLI, *cobra.Command) {
manifestsv2.Plugin{},
scorecardv2.Plugin{},
)
ansibleV2AlphaBundle, _ := plugin.NewBundle("ansible"+plugins.DefaultNameQualifier, plugin.Version{Number: 2, Stage: stage.Alpha},
// Having to call this something other than "ansible" due to it causing amibiguity issues
// when marking --plugins=ansible. Naming this "ansible" is likely a breaking change since
// our documentation mentions using --plugins=ansible instead of --plugins=ansible/v1
ansibleV2AlphaBundle, _ := plugin.NewBundle("ansible-external"+plugins.DefaultNameQualifier, plugin.Version{Number: 1, Stage: stage.Alpha},
kustomizev2Alpha.Plugin{},
ansibleexternal.Plugin{},
manifestsv2.Plugin{},
Expand Down

0 comments on commit 72da0c8

Please sign in to comment.