Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app was recently tripped up because a
uri
variable was set toserver.example.com
instead ofhttps://server.example.com
(as both can be parsed byURI.parse
).We were using:
but that resulted in:
instead of raising an exception.
So this PR adds a
uri_with_scheme
coercer to make sure the resultingURI
has a scheme eghttp
forURI:HTTP
orhttps
forURI:HTTPS
but does not let through a scheme-less uri likeURI:Generic
.To be used as:
which will raise an exception unless a valid uri that contains a scheme is used.