forked from tetratelabs/wazero
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spectest: reproduce segfault #50
Open
evacchi
wants to merge
14
commits into
main
Choose a base branch
from
finalizethis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abs#2129) Signed-off-by: Takeshi Yoneda <[email protected]>
…abs#2131) Signed-off-by: Anuraag Agrawal <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
…etratelabs#2130) Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
…oid auto-close Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
…e` to avoid auto-close" This reverts commit 5ddc150. Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was definitely a journey :D This PR should fix ... for the old compiler, but really it addresses an issue that is unrelated to the file cache, or the compiler for that matter. It was indeed related to the finalizer, but it is much more articulated than you'd think.
Indeed, the problem is a lifecycle issue that involves finalizers, and it definitely relates to invoking code that is no longer
mmap
ped; however, it was not due to a module beingunmap
ped while executing, but it is a module doing acall_indirect
on a module that was collected.The spect tests generally do not fail because the GC is not performed at each iteration, but if we force it to collect at the end of each unit test (ab4f3d8) the spec tests will fail very predictably. In fact, by allowing a bit of output, we learn that one of the tests in
linking.wast
enters (->
) a code segment with a given address (in this case0x12aba0000
) inassert_uninstantiable
, then leaves it (<-
), but then this segment is immediately released (!!
), i.e. finalized. This is because