increase coverage

attach/base_attach_impl/base_attach_impl.hpp

@@ -5,6 +5,7 @@
 #include <functional>
 #include <optional>
 #include "attach_private_data.hpp"
+#include <stdexcept>
 namespace bpftime
 {
 namespace attach
@@ -71,7 +72,8 @@ inline uint64_t bpftime_set_retval(uint64_t value)
 	} else {
 		spdlog::error(
 			"Called bpftime_set_retval, but no retval callback was set");
-		assert(false);
+		throw std::invalid_argument(
+			"Called bpftime_set_retval, but no retval callback was set");
 	}
 	return 0;
 }
@@ -87,7 +89,8 @@ inline uint64_t bpftime_override_return(uint64_t ctx, uint64_t value)
 	} else {
 		spdlog::error(
 			"Called bpftime_override_return, but no retval callback was set");
-		assert(false);
+		throw std::invalid_argument(
+			"Called bpftime_override_return, but no retval callback was set");
 	}
 	return 0;
 }

attach/frida_uprobe_attach_impl/CMakeLists.txt

@@ -23,6 +23,7 @@ set(TEST_SOURCES
     test/test_replace_attach_with_override.cpp
     test/test_attach_with_unified_interface.cpp
     test/test_attach_private_data_parsing.cpp
+    test/test_base_attach_impl.cpp
 )
 option(TEST_LCOV "option for lcov" OFF)
 add_executable(bpftime_frida_uprobe_attach_tests ${TEST_SOURCES})

attach/frida_uprobe_attach_impl/test/test_base_attach_impl.cpp

@@ -0,0 +1,32 @@
+#include "catch2/catch_test_macros.hpp"
+#include <base_attach_impl.hpp>
+#include <catch2/catch_test_macros.hpp>
+#include <cstdint>
+
+using namespace bpftime::attach;
+using namespace bpftime;
+
+TEST_CASE("Test bpftime_set_retval")
+{
+	curr_thread_override_return_callback.reset();
+	REQUIRE_THROWS(bpftime_set_retval(0));
+	bool called = false;
+	curr_thread_override_return_callback = [&](uint64_t, uint64_t) {
+		called = true;
+	};
+	bpftime_set_retval(0);
+	REQUIRE(called);
+}
+
+TEST_CASE("Test bpftime_override_return")
+{
+	curr_thread_override_return_callback.reset();
+	REQUIRE_THROWS(bpftime_override_return(0, 0));
+
+	bool called = false;
+	curr_thread_override_return_callback = [&](uint64_t, uint64_t) {
+		called = true;
+	};
+	bpftime_override_return(0, 0);
+	REQUIRE(called);
+}