Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for globalnomad-5-8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MEGUMMY1
reviewed
Jul 18, 2024
| import { useEffect } from 'react'; | ||
| import { RegisterFormProps } from './RegisterForm.types'; | ||
| import useEditMyActivity from '@/hooks/myActivity/useEditMyActivity'; | ||
| import useResetRegisterState from '../../../hooks/myActivity/useResetRegisterState'; |
MEGUMMY1
approved these changes
Jul 18, 2024
Byukchong
approved these changes
Jul 19, 2024
Comment on lines
158
to
173
| // form 제출이 가능한지 체크 | ||
| const isAllFieldsValid = () => { | ||
| const { title, description, price } = getValues(); | ||
| return ( | ||
| !!title && | ||
| !!description && | ||
| !!price && | ||
| !errors.title && | ||
| !errors.description && | ||
| !errors.price && | ||
| selectedKateogorie.name !== '' && | ||
| address !== '' && | ||
| bannerImage.length !== 0 && | ||
| isTimeFieldValid() | ||
| ); | ||
| }; |
There was a problem hiding this comment.
요기 리액트 훅폼 getValues 보다는 watch() 추천드립니다!
얼마전 보민님과도 공유한 내용인데, getValues를 쓰게되면 직접 타이핑한 값(복붙제외)만 인식이 되어서 좀 번거롭더라구요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 작업 내용
📢 전달사항
(혹시 나중에 비슷한 오류 발생 시 말씀주세용 😭)