Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Loading Spinner, 404Page, build CI #26

Merged
merged 9 commits into from
Jul 13, 2024
Merged

Feat: Loading Spinner, 404Page, build CI #26

merged 9 commits into from
Jul 13, 2024

Conversation

MEGUMMY1
Copy link
Collaborator

@MEGUMMY1 MEGUMMY1 commented Jul 12, 2024 •
edited
Loading

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ์˜ˆ์•ฝ ๋‚ด์—ญ์˜ ํ›„๊ธฐ ์ž‘์„ฑ ๋ฒ„ํŠผ๊ณผ ํ›„๊ธฐ ์ž‘์„ฑ ๋ชจ๋‹ฌ ์—ฐ๊ฒฐ
    image

  • Loading Spinner
    image

  • 404 page
    image

  • favicon, meta tag ์ถ”๊ฐ€

  • build CI

โš ๏ธ ์ด์Šˆ

๐Ÿ“ข ์ „๋‹ฌ์‚ฌํ•ญ

  • api ์—ฐ๊ฒฐ ํ›„ Loading ์ฒ˜๋ฆฌํ•  ๋•Œ <Spinner /> ์ถ”๊ฐ€ํ•ด์ฃผ์‹œ๋ฉด ๋ฉ๋‹ˆ๋‹ค!
  • ์•„๋ž˜์ฒ˜๋Ÿผ failed๊ฐ€ ๋œจ๋ฉด, Actions์—์„œ ํ•ด๋‹น push์˜ ์˜ค๋ฅ˜ ๋‚ด์—ญ ํ™•์ธ -> ํ•ด๋‹น ๋ถ€๋ถ„ Fix ํ›„ ์žฌpush ํ•˜๋ฉด ์ดˆ๋ก์ƒ‰(?)์œผ๋กœ ๋ณ€ํ•  ๊ฑฐ์˜ˆ์š”..
    image
    image

@MEGUMMY1 MEGUMMY1 requested review from bomin0830 and ssumai-kr July 12, 2024 08:26
@MEGUMMY1 MEGUMMY1 self-assigned this Jul 12, 2024
bomin0830
bomin0830 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@bomin0830 bomin0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@MEGUMMY1 MEGUMMY1 merged commit 26efffc into master Jul 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomin0830 bomin0830 bomin0830 approved these changes

@ssumai-kr ssumai-kr Awaiting requested review from ssumai-kr

Assignees

@MEGUMMY1 MEGUMMY1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MEGUMMY1 @bomin0830