Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bower.json #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added bower.json #44

wants to merge 1 commit into from

Conversation

bharat-dpd
Copy link

as our module is already registered on bower. New user face some problem as may they don't know how to clone git repo with bower. For this i have added the bower.json file

@bharat-dpd
Copy link
Author

As we know this is PURE angular module, there is no others dependencies. So
I didn't get you by these line " currently fails to add required files".

On Tue, Jul 14, 2015 at 1:45 PM, MrJean [email protected] wrote:

@eu81273 https://github.com/eu81273 Is it possible to merge this? When
using automatic dependency wiring, it currently fails to add required files.


Reply to this email directly or view it on GitHub
#44 (comment)
.

@MrJean
Copy link

MrJean commented Jul 14, 2015

@bharat-dpd When installing angular-treeview using Bower, automatic dependency wiring through wiredep (https://github.com/taptapship/wiredep) does not work because a bower.json is not defined and source files (JS/CSS) cannot be wired into source files of the project. See the Bower docs why I added the bower.json.

I know this module does not have dependencies but when using this module it becomes a dependency of the project where used. These are two different things.

@bharat-dpd
Copy link
Author

this is because of our main key in bower file, I suppose not sure on this I
have to dig more on it.

On Tue, Jul 14, 2015 at 3:13 PM, MrJean [email protected] wrote:

@bharat-dpd https://github.com/bharat-dpd When installing
angular-treeview using Bower, automatic dependency wiring through wiredep (
https://github.com/taptapship/wiredep) does not work because a bower.json
is not defined and source files (JS/CSS) cannot be wired into source files
of the project. See the Bower docs why I added the bower.json.

I know this module does not have dependencies but when using this module
it becomes a dependency of the project where used. These are two different
things.


Reply to this email directly or view it on GitHub
#44 (comment)
.

@MrJean
Copy link

MrJean commented Jul 14, 2015

@bharat-dpd Obviously your pull request will not fix the problem because the files defined in your main field are incorrect. You are using dash notation, but it's actually dot notation.

This is my fork https://github.com/MrJean/angular.treeview and works like a charm when adding it as bower component

@bharat-dpd
Copy link
Author

Ok you have removed
"dependencies": {
"angular": "~1.2.7"
}
key from bower.

If you allow I will remove this key form my fork also and make pull request
again.

On Tue, Jul 14, 2015 at 3:57 PM, MrJean [email protected] wrote:

@bharat-dpd https://github.com/bharat-dpd Obviously your pull request
will not fix the problem because the files defined in your main field are
incorrect. You are using dash notation, but it's actually dot notation.

This is my fork https://github.com/MrJean/angular.treeview and works like
a charm when adding it as bower component


Reply to this email directly or view it on GitHub
#44 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants