-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bower.json #44
base: master
Are you sure you want to change the base?
added bower.json #44
Conversation
As we know this is PURE angular module, there is no others dependencies. So On Tue, Jul 14, 2015 at 1:45 PM, MrJean [email protected] wrote:
|
@bharat-dpd When installing angular-treeview using Bower, automatic dependency wiring through wiredep (https://github.com/taptapship/wiredep) does not work because a bower.json is not defined and source files (JS/CSS) cannot be wired into source files of the project. See the Bower docs why I added the bower.json. I know this module does not have dependencies but when using this module it becomes a dependency of the project where used. These are two different things. |
this is because of our main key in bower file, I suppose not sure on this I On Tue, Jul 14, 2015 at 3:13 PM, MrJean [email protected] wrote:
|
@bharat-dpd Obviously your pull request will not fix the problem because the files defined in your main field are incorrect. You are using dash notation, but it's actually dot notation. This is my fork https://github.com/MrJean/angular.treeview and works like a charm when adding it as bower component |
Ok you have removed If you allow I will remove this key form my fork also and make pull request On Tue, Jul 14, 2015 at 3:57 PM, MrJean [email protected] wrote:
|
as our module is already registered on bower. New user face some problem as may they don't know how to clone git repo with bower. For this i have added the bower.json file