Split audio source error message #216 #238
Conversation
src/layer/audio-source.ts
Outdated
| if (isNaN(this.currentTime)) { | ||
| this.source.currentTime = this.sourceStartTime | ||
| } else { | ||
| this.source.currentTime = this.currentTime + this.sourceStartTime | ||
| } |
There was a problem hiding this comment.
Please undo this change, it was from another recent PR
src/layer/audio-source.ts
Outdated
| @@ -86,11 +86,16 @@ function AudioSourceMixin<OptionsSuperclass extends BaseOptions> (superclass: Co | |||
|
|
|||
| const load = () => { | |||
| // TODO: && ? | |||
There was a problem hiding this comment.
This can go now. Not sure what I was thinking when I wrote that, but it no longer applies.
|
Also please run the following command to fix the linter warnings: npm run fix |
|
Hey Clabe! I have undone the changes from another PR, removed that comment on line 88, fixed linter warnings and pushed the changes to the PR |
src/layer/audio-source.ts
Outdated
| } | ||
|
|
||
| if (this.source.duration < this.sourceStartTime) { | ||
| throw new Error('Invalid options.sourceStartTime. It must greater than options.source.duration.') |
There was a problem hiding this comment.
This should be the opposite:
options.sourceStartTime cannot exceed options.source.duration.
There was a problem hiding this comment.
I think it's alright. If sourceStartTime is greater than source.duration, it will throw an error, which implies it won't throw an error if sourceStartTime is less than or equal to duration
There was a problem hiding this comment.
Hi, sorry for the late reply, starting a new job. Yea sourceStartTime must be less than or equal to duration, but the error message says it must be greater than duration.
There was a problem hiding this comment.
Congrats on the new job! Alright, I will fix it up immediately
There was a problem hiding this comment.
Thanks!!
I meant you should change the error message to be the opposite of what it was. The condition itself was correct. So,
if (this.sourceStartTime > this.source.duration) {
throw new Error('options.sourceStartTime cannot exceed options.source.duration')
}There was a problem hiding this comment.
Hi! Sorry, I have been sick terribly so couldn't attend this issue earlier.
Ah, you meant the Error message itself. I feel dumb now not gonna lie. Let me fix that up real quick, and apologies for the carelessness
|
Hang on, I started running the checks and then something came up. I need to merge this once the checks run again. |
* added bindings in reference to apid * updates * rename toRustCore * add type alias * lint
Split the error message into two more descriptive ones that are validated individually.