Fix target leakage in MeanSegmentEncoderTransform
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2024 07:20
egoriyaa
changed the title
target leakage in MeanSegmentEncoderTransform
egoriyaa
changed the title
target leakage in MeanSegmentEncoderTransformtarget leakage in MeanSegmentEncoderTransform
egoriyaa
commented
Nov 7, 2024
| pd.testing.assert_frame_equal(transformed_simple_df, transformed_df) | ||
|
|
||
|
|
||
| def test_subset_segments(simple_ts): |
There was a problem hiding this comment.
We have such type of tests in inference tests
|
🚀 Deployed on https://deploy-preview-503--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 90.51% 90.51%
=======================================
Files 247 247
Lines 16516 16508 -8
=======================================
- Hits 14950 14943 -7
+ Misses 1566 1565 -1 ☔ View full report in Codecov by Sentry. |
egoriyaa
commented
Nov 7, 2024
| column = transformed_df.loc[:, pd.IndexSlice[segment, "segment_code"]] | ||
| assert column.dtype == "category", "Column type is not category" | ||
| assert np.all(column == column.iloc[0]), "Values are not the same for the whole column" | ||
| codes.add(column.iloc[0]) | ||
| assert codes == {0, 1}, "Codes are not 0 and 1" | ||
|
|
||
|
|
||
| def test_subset_segments(simple_ts): |
There was a problem hiding this comment.
The same as for MeanSegmentEncoder
d-a-bunin
reviewed
Nov 8, 2024
d-a-bunin
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #400