Install resource folder and use correct topic for rviz elevation map #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: It's actually just not using the namespace on the XML launch files, but is using the namespace on the python launch files. A better fix for RVIZ not subscribing to the correct topic would be to make them all consistent. I'll implement that then bring it back out of draft. |
Ryanf55
force-pushed
the
default-rviz-sargans-works
branch
from
6cc4a2e to
d9b76d1
Compare
Ryanf55
force-pushed
the
default-rviz-sargans-works
branch
from
d9b76d1 to
af120b1
Compare
* Resource folder needs to be installed, and will be empty for people who don't have sargans.tif * RVIZ was subscribed to the wrong topic because not all map_publisher nodes were launched with a namespace Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
default-rviz-sargans-works
branch
from
af120b1 to
52300fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a symlink to the terrain-models, and this gets it installed from the source tree. The resource folder needs to be installed and will be empty for people who don't have sargans.tif. In order for it to be tracked by git and not fail the build in case its empty, I added a placeholder
.gitkeepfolder.RVIZ was subscribed to the wrong topic, so I fixed that too.
With the above changes, the XML launch file works: