Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation docs #61

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Add installation docs #61

merged 1 commit into from
Aug 21, 2019

Conversation

njgheorghita
Copy link
Contributor

What was wrong?

Installation docs

Cute Animal Picture

image

- ``docker pull ethpm/ethpm:latest``
- ``docker run ethpm/ethpm:latest``

Homebrew
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this one isn't the recommended one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None at all - just went with pypi to encourage using more python things. Do you think Homebrew should be recommended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It makes it less of a python tool and more of a general purpose tool which I think is a good thing, and it installs into the global namespace rather than whatever venv they have active (or at least it should...?).

Thoughts? Ideally, our brew install would install itself into it's own venv (does it do that?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, it would be nice to get an apt-get install path available soon too for all the linux folks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(does it do that?)
yup!

Added an apt-get install path to issue #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants