fix index underflow in GetWithdrawalRequestsByFilter / GetConsolidati…

…onRequestsByFilter
ethpandaops · Oct 16, 2024 · 64038db · 64038db
1 parent 60a1bf1
commit 64038db
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/services/chainservice_objects.go b/services/chainservice_objects.go
@@ -442,7 +442,12 @@ func (bs *ChainService) GetWithdrawalRequestsByFilter(filter *dbtypes.Withdrawal
 	}
 
 	// load older objects from db
-	dbPage := pageIdx - cachedPages
+	var dbPage uint64
+	if pageIdx > cachedPages {
+		dbPage = pageIdx - cachedPages
+	} else {
+		dbPage = 0
+	}
 	dbCacheOffset := uint64(pageSize) - (cachedMatchesLen % uint64(pageSize))
 
 	var dbObjects []*dbtypes.WithdrawalRequest
@@ -571,7 +576,12 @@ func (bs *ChainService) GetConsolidationRequestsByFilter(filter *dbtypes.Consoli
 	}
 
 	// load older objects from db
-	dbPage := pageIdx - cachedPages
+	var dbPage uint64
+	if pageIdx > cachedPages {
+		dbPage = pageIdx - cachedPages
+	} else {
+		dbPage = 0
+	}
 	dbCacheOffset := uint64(pageSize) - (cachedMatchesLen % uint64(pageSize))
 
 	var dbObjects []*dbtypes.ConsolidationRequest