Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECBP-1110: Deactivate MESS #520

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Conversation

meowsbits
Copy link
Member

@meowsbits meowsbits commented Dec 11, 2023

Turn off the artificial finality mechanism ECBP-1100's MESS (Modified Exponential Scoring) in Core-Geth for Ethereum Classic.

Rendered document: https://github.com/meowsbits/ECIPs/blob/ecbp1110/_specs/ecip-1110.md

FYI I'll also be updating https://meowsbits.github.io/51-percent-docs/ this week, which provides some useful context.

@gitr0n1n gitr0n1n requested a review from a team December 12, 2023 23:34
@gitr0n1n
Copy link
Contributor

gitr0n1n commented Dec 12, 2023

To clarify @meowsbits, MESS still exists in the client as a tool should it ever be needed again by client users, but this removes the default activation setting and adjusted the setting to "off" by default?

Also for status, do we want to update 1100 with "Replaced by 1099" or something to that effect? Or keep as active, since it is still present in the client, but just not turned on by default?

@bobsummerwill
Copy link
Member

Discussion ongoing here: https://github.com/orgs/ethereumclassic/discussions/522

@gitr0n1n
Copy link
Contributor

gitr0n1n commented Jan 9, 2024

Now that we have a a block set for Mordor. Is this ECIP in a final state for review? @ethereumclassic/ecip-editors there does not appear to be any contention with this ECIP proposal and discussion has been open at:
https://github.com/orgs/ethereumclassic/discussions/522

Note it appears everyone agree MESS should not exist anymore. But the discussion is now whether to deactivate/remove fully. Noting deactivate and remove could be two stage. I'm approving the PR because the deactivate of MESS is no contentious. Removal of MESS entirely is where there is some conversation to still be had on the topic. Should removal be the deemed route, this PR certainly could be updated to reflect that.

I'll let you execute the merge @meowsbits in case you notice anything that needs to be cleaned up in the document.

Copy link
Contributor

@gitr0n1n gitr0n1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mordor activation set 10 hours ago. Discussion on the topic seems to support this change without any contention. My understanding is the MESS tool is not being removed at the moment, but its default is OFF due to the abundance of friendly/loyal hashrate that is securing the ETC network since Sept 2022.

@gitr0n1n
Copy link
Contributor

gitr0n1n commented Jan 9, 2024

Also for status, do we want to update 1100 with "Replaced by 1099" or something to that effect? Or keep as active, since it is still present in the client, but just not turned on by default?

@meowsbits can you comment on this? How should we adjust the status, if at all?

@meowsbits
Copy link
Member Author

I like your Replaced idea on 1100, the original MESS (activation) spec, concurrent with this. Although I think leaving it would be logical too, I guess it will be more understandable if it's association with this 1110 spec is documented. Will do.

@meowsbits
Copy link
Member Author

CI failed because Ruby's bundler install failed. Unrelated to changes here, so I'll go ahead with merge and fix the bundler issue later.

https://github.com/ethereumclassic/ECIPs/actions/runs/7463281525/job/20307577984?pr=520

Run gem install bundler
ERROR:  Error installing bundler:
	The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.6.10.210.
Error: Process completed with exit code 1.

@meowsbits meowsbits merged commit 936fae0 into ethereumclassic:master Jan 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants