Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue#5674 #5710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ritvikPuranik
Copy link

for injected providers, it was looking for a selected account by default. if there's no selected account(-null), toChecksumAddress() was throwing an error, causing the dispatcher to propagate the error. My fix sets the first account as default selected account - once the user explicitly sets an account, it behaves as usual

This fix also addresses #5604 , issue #5666 (where it is identified that "the environment dropdown still shows Injected provider but the accounts list is empty") and #5432

The issue -
Screenshot 2025-01-29 at 3 21 56 AM

After the fix -
Screenshot 2025-01-29 at 3 23 49 AM

…ted account by default. if there's no selected account(-null), toChecksumAddress() was throwing an error, causing the dispatcher to propagate the error. My fix sets the first account as default selected account - once the user explicitly sets an account, it behaves as usual
Copy link

netlify bot commented Jan 28, 2025

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 00c7e78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant