Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combomethod type hints #237

Closed
wants to merge 1 commit into from
Closed

Conversation

darwintree
Copy link

@darwintree darwintree commented Nov 17, 2022

What was wrong?

Issue #236

How was it fixed?

This commit adopts the solution from here. It uses ParamSpec and Concatenate added in python3.10. And in order to use this feature minor to 3.10, typing-extensions dependency is added in setup.py

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@darwintree
Copy link
Author

It seems mypy should update to a newer version to support ParamSpec, but the update will bring about tests failure. I'm looking into how to fix it

@darwintree darwintree closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant