ignore link first check for images and added test

ethereum · Jun 20, 2024 · 97e667a · 97e667a
1 parent db50295
commit 97e667a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/eipw-lint/src/lints/markdown/link_first.rs b/eipw-lint/src/lints/markdown/link_first.rs
@@ -140,8 +140,8 @@ impl<'a, 'b, 'c> tree::Visitor for Visitor<'a, 'b, 'c> {
         Ok(())
     }
 
-    fn enter_image(&mut self, ast: &Ast, link: &NodeLink) -> Result<Next, Self::Error> {
-        self.check(ast, &link.title)
+    fn enter_image(&mut self, _: &Ast, _: &NodeLink) -> Result<Next, Self::Error> {
+        Ok(Next::SkipChildren)
     }
 
     fn enter_footnote_reference(&mut self, ast: &Ast, refn: &str) -> Result<Next, Self::Error> {

diff --git a/eipw-lint/tests/lint_markdown_link_first.rs b/eipw-lint/tests/lint_markdown_link_first.rs
@@ -59,3 +59,25 @@ hello
 
     assert_eq!(reports, "");
 }
+
+#[tokio::test]
+async fn img_then_linked() {
+    let src = r#"---
+header: value1
+---
+![ello](../assets/example.svg)
+
+[ello](https://example.com/)
+"#;
+
+    let reports = Linter::<Text<String>>::default()
+        .clear_lints()
+        .deny("markdown-link-first", LinkFirst("ello"))
+        .check_slice(None, src)
+        .run()
+        .await
+        .unwrap()
+        .into_inner();
+
+    assert_eq!(reports, "");
+}