Update ERC-7683: Extending the standard #689
Merged
+261
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
eip-review-bot
approved these changes
Oct 28, 2024
mrice32
changed the title
eip-review-bot
approved these changes
Oct 29, 2024
auto-merge was automatically disabled
October 30, 2024 02:26
Head branch was pushed to by a user without write access
mrice32
force-pushed
the
mrice32/7683-next
branch
from
3cdc87a
to
6dd691a
Compare
eip-review-bot
previously approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 02:37
Head branch was pushed to by a user without write access
eip-review-bot
previously approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 02:40
Head branch was pushed to by a user without write access
eip-review-bot
previously approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 02:45
Head branch was pushed to by a user without write access
eip-review-bot
approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 02:50
Head branch was pushed to by a user without write access
mrice32
force-pushed
the
mrice32/7683-next
branch
from
304dec6
to
33e5dd4
Compare
eip-review-bot
previously approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 03:22
Head branch was pushed to by a user without write access
eip-review-bot
approved these changes
Oct 30, 2024
|
The commit eec9ba7 (as a parent of 7940adb) contains errors. |
auto-merge was automatically disabled
October 30, 2024 22:15
Head branch was pushed to by a user without write access
mrice32
force-pushed
the
mrice32/7683-next
branch
from
eec9ba7
to
461aeb3
Compare
eip-review-bot
previously approved these changes
Oct 30, 2024
auto-merge was automatically disabled
October 30, 2024 22:18
Head branch was pushed to by a user without write access
mrice32
force-pushed
the
mrice32/7683-next
branch
from
461aeb3
to
5cca59c
Compare
eip-review-bot
approved these changes
Oct 30, 2024
Signed-off-by: Matt Rice <[email protected]>
auto-merge was automatically disabled
October 30, 2024 22:19
Head branch was pushed to by a user without write access
mrice32
force-pushed
the
mrice32/7683-next
branch
from
5cca59c
to
ac4656b
Compare
eip-review-bot
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a few updates to ERC-7683. These updates are intended to make the language and functionality in the ERC capture more use cases than originally foreseen, require less (or no) protocol-specific code and casework for fillers, and provide visibility into the opaque bytes fields used in the standard.
See this PR for wider discussion of these changes.
Notable changes: