Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/types: transaction conditional HexOrDecimal deser #414

Open
wants to merge 1 commit into
base: optimism
Choose a base branch
from
Open

core/types: transaction conditional HexOrDecimal deser #414

wants to merge 1 commit into from
+24 −6

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented Oct 25, 2024 •
edited
Loading

Description
BlockNumber and Timestamp constraints must use a hex string. We can be more flexible and support specifying with a number as well.

Tests

Deser transaction conditional test addition

@hamdiallam hamdiallam requested a review from a team as a code owner October 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/op-geth-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamdiallam