-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isthmus: operator fee #388
Draft
yuwen01
wants to merge
12
commits into
ethereum-optimism:optimism
Choose a base branch
from
yuwen01:yuwen/operator-fee
base: optimism
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+325
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
reviewed
Oct 22, 2024
GasLimit: header.GasLimit, | ||
Random: random, | ||
L1CostFunc: types.NewL1CostFunc(config, statedb), | ||
OperatorCostFunc: types.NewOperatorCostFunc(config, statedb), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lean towards not adding a new hook and just making the L1 cost function more generic, a better name for it would be L2CostFunc
which would imply it does the L2 specific fee calculations. Curious what other people think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the operator fee, as described in this design doc and this spec
Note that this PR proposes that this be added to the Holocene hardfork instead of Isthmus. This can be easily changed if the accompanying changes don't make it into the holocene code freeze.