-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating batcher and proposer configuration pages #1276
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request encompasses documentation updates for the Optimism protocol, focusing on two key configuration files: Possibly related issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
pages/builders/chain-operators/configuration/proposer.mdx (1)
23-23
: Use sentence case for the heading.According to the style guidelines for H3 headings, only the first word should be capitalized unless the word is a proper noun or acronym. Please adjust "Additional Guidance" to "Additional guidance."
-### Additional Guidance +### Additional guidancepages/builders/chain-operators/configuration/batcher.mdx (4)
15-15
: Use sentence case for the H2 heading.For consistency with the documentation style guidelines, only the first word in an H2 heading should be capitalized (unless it is a proper noun or acronym).
-## Batcher Policy +## Batcher policy
21-21
: Remove the comma before “because.”The “because” clause here is essential to conveying the reason there are no restrictions. Remove the comma to adhere to standard grammar usage.
-... with no restrictions, because both are fully secured by L1. +... with no restrictions because both are fully secured by L1.🧰 Tools
🪛 LanguageTool
[formatting] ~21-~21: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tions and calldata, with no restrictions, because both are fully secured by L1. | | Batch...(COMMA_BEFORE_BECAUSE)
23-23
: Use sentence case for the H3 heading.Headings at the H3 level should only capitalize the first word (unless dealing with a named entity or acronym).
-### Additional Guidance +### Additional guidance
117-117
: Fix the verb form.Change “configures” to “configured” to correct the grammar.
-The batcher can be configures with the following new flags and default parameters: +The batcher can be configured with the following new flags and default parameters:🧰 Tools
🪛 LanguageTool
[grammar] ~117-~117: There may an error in the verb form ‘be configures’.
Context: ...oint flags. The batcher can be configures with the following new flags and defaul...(MD_BE_NON_VBP)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
next-env.d.ts
(1 hunks)pages/builders/chain-operators/configuration/batcher.mdx
(30 hunks)pages/builders/chain-operators/configuration/proposer.mdx
(12 hunks)
✅ Files skipped from review due to trivial changes (1)
- next-env.d.ts
🧰 Additional context used
📓 Path-based instructions (2)
pages/builders/chain-operators/configuration/proposer.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/builders/chain-operators/configuration/batcher.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🪛 LanguageTool
pages/builders/chain-operators/configuration/batcher.mdx
[formatting] ~21-~21: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tions and calldata, with no restrictions, because both are fully secured by L1. | | Batch...
(COMMA_BEFORE_BECAUSE)
[grammar] ~103-~103: Did you mean to use ‘who’s’ here (the contracted form of ‘who’ and ‘is/has’)?
Context: ...ng, which skips individual transactions whose estimated compressed L1 DA usage goes o...
(WHOSE_WHO_S)
[grammar] ~117-~117: There may an error in the verb form ‘be configures’.
Context: ...oint flags. The batcher can be configures with the following new flags and defaul...
(MD_BE_NON_VBP)
🔇 Additional comments (1)
pages/builders/chain-operators/configuration/batcher.mdx (1)
97-97
: Flagging potential heading style inconsistency for manual review."Batcher Sequencer Throttling" may not strictly follow sentence case if "Batcher" and "Sequencer" are not proper nouns. If they are simply descriptive terms, consider lowercasing them to meet style guidelines. Otherwise, confirm whether these are treated as brand or product names.
Description
Resources:
Meta note:
We should get in the habit of reviewing the release notes to update the docs