Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating batcher and proposer configuration pages #1276

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Jan 24, 2025

Description

  • Moving proposer policy out of the batcher page into the proposer page
  • Adding configuration recommendations

Resources:

Meta note:

We should get in the habit of reviewing the release notes to update the docs

@sbvegan sbvegan requested a review from a team as a code owner January 24, 2025 01:03
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 47a4b20
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6792e6e187b19c00080fdb11
😎 Deploy Preview https://deploy-preview-1276--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 24, 2025

📝 Walkthrough

Walkthrough

The pull request encompasses documentation updates for the Optimism protocol, focusing on two key configuration files: batcher.mdx and proposer.mdx. The changes introduce comprehensive policy sections that provide detailed guidance for chain operators. In the batcher.mdx, a new "Batcher Policy" section is added, explaining parameters like data availability types, batch submission frequency, and output frequency. The proposer.mdx receives a similar treatment with a new "Proposer policy" section, specifically highlighting the "Output Frequency" parameter and its role in posting L2 output roots to L1. Additionally, a minor comment modification is made in the next-env.d.ts file, updating a documentation reference.

Possibly related issues

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
pages/builders/chain-operators/configuration/proposer.mdx (1)

23-23: Use sentence case for the heading.

According to the style guidelines for H3 headings, only the first word should be capitalized unless the word is a proper noun or acronym. Please adjust "Additional Guidance" to "Additional guidance."

-### Additional Guidance
+### Additional guidance
pages/builders/chain-operators/configuration/batcher.mdx (4)

15-15: Use sentence case for the H2 heading.

For consistency with the documentation style guidelines, only the first word in an H2 heading should be capitalized (unless it is a proper noun or acronym).

-## Batcher Policy
+## Batcher policy

21-21: Remove the comma before “because.”

The “because” clause here is essential to conveying the reason there are no restrictions. Remove the comma to adhere to standard grammar usage.

-... with no restrictions, because both are fully secured by L1.
+... with no restrictions because both are fully secured by L1.
🧰 Tools
🪛 LanguageTool

[formatting] ~21-~21: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tions and calldata, with no restrictions, because both are fully secured by L1. | | Batch...

(COMMA_BEFORE_BECAUSE)


23-23: Use sentence case for the H3 heading.

Headings at the H3 level should only capitalize the first word (unless dealing with a named entity or acronym).

-### Additional Guidance
+### Additional guidance

117-117: Fix the verb form.

Change “configures” to “configured” to correct the grammar.

-The batcher can be configures with the following new flags and default parameters:
+The batcher can be configured with the following new flags and default parameters:
🧰 Tools
🪛 LanguageTool

[grammar] ~117-~117: There may an error in the verb form ‘be configures’.
Context: ...oint flags. The batcher can be configures with the following new flags and defaul...

(MD_BE_NON_VBP)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec8c9ac and 47a4b20.

📒 Files selected for processing (3)
  • next-env.d.ts (1 hunks)
  • pages/builders/chain-operators/configuration/batcher.mdx (30 hunks)
  • pages/builders/chain-operators/configuration/proposer.mdx (12 hunks)
✅ Files skipped from review due to trivial changes (1)
  • next-env.d.ts
🧰 Additional context used
📓 Path-based instructions (2)
pages/builders/chain-operators/configuration/proposer.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/chain-operators/configuration/batcher.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
pages/builders/chain-operators/configuration/batcher.mdx

[formatting] ~21-~21: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tions and calldata, with no restrictions, because both are fully secured by L1. | | Batch...

(COMMA_BEFORE_BECAUSE)


[grammar] ~103-~103: Did you mean to use ‘who’s’ here (the contracted form of ‘who’ and ‘is/has’)?
Context: ...ng, which skips individual transactions whose estimated compressed L1 DA usage goes o...

(WHOSE_WHO_S)


[grammar] ~117-~117: There may an error in the verb form ‘be configures’.
Context: ...oint flags. The batcher can be configures with the following new flags and defaul...

(MD_BE_NON_VBP)

🔇 Additional comments (1)
pages/builders/chain-operators/configuration/batcher.mdx (1)

97-97: Flagging potential heading style inconsistency for manual review.

"Batcher Sequencer Throttling" may not strictly follow sentence case if "Batcher" and "Sequencer" are not proper nouns. If they are simply descriptive terms, consider lowercasing them to meet style guidelines. Otherwise, confirm whether these are treated as brand or product names.

@sbvegan sbvegan merged commit c1d920b into main Jan 24, 2025
8 checks passed
@sbvegan sbvegan deleted the sb/batcher-config-updates branch January 24, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants