Added NLog Layout support for WebHookUrl

eth0izzle · Nov 13, 2022 · 5c7a43e · 5c7a43e
1 parent 7241b0d
commit 5c7a43e
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/NLog.Slack/SlackTarget.cs b/NLog.Slack/SlackTarget.cs
@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using NLog.Common;
 using NLog.Config;
+using NLog.Layouts;
 using NLog.Slack.Models;
 using NLog.Targets;
 
@@ -11,7 +12,7 @@ namespace NLog.Slack
     public class SlackTarget : TargetWithContext
     {
         [RequiredParameter]
-        public string WebHookUrl { get; set; }
+        public Layout WebHookUrl { get; set; }
 
         public bool Compact { get; set; }
 
@@ -22,13 +23,6 @@ public class SlackTarget : TargetWithContext
 
         protected override void InitializeTarget()
         {
-            if (String.IsNullOrWhiteSpace(this.WebHookUrl))
-                throw new ArgumentOutOfRangeException("WebHookUrl", "Webhook URL cannot be empty.");
-
-            Uri uriResult;
-            if (!Uri.TryCreate(this.WebHookUrl, UriKind.Absolute, out uriResult))
-                throw new ArgumentOutOfRangeException("WebHookUrl", "Webhook URL is an invalid URL.");
-
             if (!this.Compact && this.ContextProperties.Count == 0)
             {
                 this.ContextProperties.Add(new TargetPropertyWithContext("Process Name", Layout = "${machinename}\\${processname}"));
@@ -55,8 +49,12 @@ private void SendToSlack(AsyncLogEventInfo info)
         {
             var message = RenderLogEvent(Layout, info.LogEvent);
 
+            var webHookUrl = RenderLogEvent(WebHookUrl, info.LogEvent);
+            if (String.IsNullOrWhiteSpace(webHookUrl))
+                throw new ArgumentOutOfRangeException("WebHookUrl", "Webhook URL cannot be empty.");
+
             var slack = SlackMessageBuilder
-                .Build(this.WebHookUrl)
+                .Build(webHookUrl)
                 .OnError(e => info.Continuation(e))
                 .WithMessage(message);
 
@@ -87,7 +85,7 @@ private void SendToSlack(AsyncLogEventInfo info)
                 var exceptionAttachment = new Attachment(exception.Message) { Color = color };
                 exceptionAttachment.Fields.Add(new Field("StackTrace") {
                     Title = $"Type: {exception.GetType().ToString()}",
-                    Value = exception.StackTrace ?? "N/A"
+                    Value = exception.ToString()
                 });
 
                 slack.AddAttachment(exceptionAttachment);