Use utilities/whoami endpoint from FirecREST, when possible, to determine the username
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
changed the title
utilities/whoami endpoint from firecrest, when possible, to determine the username
ekouts
changed the title
utilities/whoami endpoint from firecrest, when possible, to determine the usernameutilities/whoami endpoint from FirecREST, when possible, to determine the username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot get rid of the pyjwt dependency immediately because the old
whoamimethod of pyfirecrest used to take no argument, but theutilities/whoamiendpoint of firecrest needs the machine name.In order to not break compatibility, it makes a request when the machine is given and still uses the pyjwt library otherwise.