Update how-to-get-key-by-prefix doc. #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celestehorgan
suggested changes
Mar 19, 2024
| @@ -4,6 +4,32 @@ description: Guide to extracting etcd keys by their prefix | |||
| weight: 300 | |||
| --- | |||
|
|
|||
| ## Pre-requisites | |||
|
|
|||
| * [Install tools](https://etcd.io/docs/v3.5/install/) | |||
There was a problem hiding this comment.
Suggested change
| * [Install tools](https://etcd.io/docs/v3.5/install/) | |
| * [Install etcdctl](https://etcd.io/docs/v3.5/install/) |
jmhbnz
approved these changes
Mar 19, 2024
|
|
||
| ### Example | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: MD012/no-multiple-blanks: Multiple consecutive blank lines [Expected: 1; Actual: 2]markdownlint
Signed-off-by: Fu, Wei <[email protected]>
khanhtc1202
reviewed
Mar 19, 2024
| @@ -4,6 +4,31 @@ description: Guide to extracting etcd keys by their prefix | |||
| weight: 300 | |||
| --- | |||
|
|
|||
| ## Pre-requisites | |||
|
|
|||
| * [Install etcdctl](https://etcd.io/docs/v3.5/install/) | |||
There was a problem hiding this comment.
Suggested change
| * [Install etcdctl](https://etcd.io/docs/v3.5/install/) | |
| * Install [etcdctl](https://etcd.io/docs/v3.5/install/) |
nits, I think it's better to make the header of the session unified with other cross pages in this docs
https://github.com/etcd-io/website/blob/main/content/en/docs/v3.6/tutorials/how-to-watch-keys.md#prerequisites
There was a problem hiding this comment.
I think etcdctl is about what is etcdctl. [install etcdctl] is about how to get it.
I don't think we should just highlight the etcdctl.
|
ping @wenjiaswe ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #797