Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.6 changelog to cover the go-grpc-middleware/providers/promet… #19311

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 31, 2025

Copy link
Contributor

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (1216d08) to head (49c2249).
Report is 7 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19311   +/-   ##
=======================================
  Coverage   68.80%   68.81%           
=======================================
  Files         420      420           
  Lines       35693    35693           
=======================================
+ Hits        24558    24561    +3     
- Misses       9701     9704    +3     
+ Partials     1434     1428    -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1216d08...49c2249. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, dims, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 497d9b5 into etcd-io:main Jan 31, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants