Added eslint to webpack config

estruyf · Sep 27, 2024 · 6fd526e · 6fd526e
1 parent 017a2d7
commit 6fd526e
Show file tree

Hide file tree

Showing 123 changed files with 555 additions and 347 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -13,6 +13,8 @@
     "no-unused-expressions": "error",
     "curly": "error",
     "class-methods-use-this": "warn",
-    "no-console": "warn"
+    "no-console": "warn",
+    "@typescript-eslint/no-empty-interface": "off",
+    "no-extra-boolean-cast": "off"
   }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2869,6 +2869,7 @@
     "dotenv": "^16.3.1",
     "downshift": "6.0.6",
     "eslint": "^8.33.0",
+    "eslint-webpack-plugin": "^4.2.0",
     "fuse.js": "6.5.3",
     "github-directory-downloader": "^1.3.6",
     "glob": "^10.3.12",

diff --git a/src/commands/Chatbot.ts b/src/commands/Chatbot.ts
@@ -33,26 +33,31 @@ export class Chatbot {
 
     const cspSource = webView.webview.cspSource;
 
+    const fetchLocalization = async (requestId: string) => {
+      if (!requestId) {
+        return;
+      }
+
+      const fileContents = await getLocalizationFile();
+
+      webView.webview.postMessage({
+        command: GeneralCommands.toVSCode.getLocalization,
+        requestId,
+        payload: fileContents
+      });
+    };
+
     webView.webview.onDidReceiveMessage(async (message) => {
-      switch (message.command) {
+      const { command, requestId, payload, data } = message;
+
+      switch (command) {
         case PreviewCommands.toVSCode.open:
-          if (message.data) {
-            commands.executeCommand('vscode.open', message.data);
+          if (payload || data) {
+            commands.executeCommand('vscode.open', payload || data);
           }
-          return;
+          break;
         case GeneralCommands.toVSCode.getLocalization:
-          const { requestId } = message;
-          if (!requestId) {
-            return;
-          }
-
-          const fileContents = await getLocalizationFile();
-
-          webView.webview.postMessage({
-            command: GeneralCommands.toVSCode.getLocalization,
-            requestId,
-            payload: fileContents
-          });
+          fetchLocalization(requestId);
           return;
       }
     });

diff --git a/src/commands/Folders.ts b/src/commands/Folders.ts
@@ -401,8 +401,8 @@ export class Folders {
           folder.locales && folder.locales.length > 0 ? folder.locales : i18nSettings;
 
         let defaultLocale;
-        let sourcePath = folderPath;
-        let localeFolders: ContentFolder[] = [];
+        const sourcePath = folderPath;
+        const localeFolders: ContentFolder[] = [];
 
         if (i18nConfig && i18nConfig.length > 0) {
           for (const i18n of i18nConfig) {

diff --git a/src/commands/Preview.ts b/src/commands/Preview.ts
@@ -110,27 +110,32 @@ export class Preview {
       webView.dispose();
     });
 
+    const fetchLocalization = async (requestId: string) => {
+      if (!requestId) {
+        return;
+      }
+
+      const fileContents = await getLocalizationFile();
+
+      webView.webview.postMessage({
+        command: GeneralCommands.toVSCode.getLocalization,
+        requestId,
+        payload: fileContents
+      });
+    };
+
     webView.webview.onDidReceiveMessage(async (message) => {
-      switch (message.command) {
+      const { command, payload, requestId } = message;
+
+      switch (command) {
         case PreviewCommands.toVSCode.open:
-          if (message.payload) {
-            commands.executeCommand('vscode.open', message.payload);
+          if (payload) {
+            commands.executeCommand('vscode.open', payload);
           }
-          return;
+          break;
         case GeneralCommands.toVSCode.getLocalization:
-          const { requestId } = message;
-          if (!requestId) {
-            return;
-          }
-
-          const fileContents = await getLocalizationFile();
-
-          webView.webview.postMessage({
-            command: GeneralCommands.toVSCode.getLocalization,
-            requestId,
-            payload: fileContents
-          });
-          return;
+          fetchLocalization(requestId);
+          break;
       }
     });
 

diff --git a/src/commands/Project.ts b/src/commands/Project.ts
@@ -42,7 +42,7 @@ categories: []
 
     // Initialize command
     subscriptions.push(
-      commands.registerCommand(COMMAND_NAME.init, async (cb: Function) => {
+      commands.registerCommand(COMMAND_NAME.init, async (cb: () => void) => {
         await Project.init();
 
         if (cb) {

diff --git a/src/commands/i18n.ts b/src/commands/i18n.ts
@@ -403,8 +403,8 @@ export class i18n {
     sourceLocale: I18nConfig,
     targetLocale: I18nConfig
   ) {
-    return new Promise<ParsedFrontMatter>(async (resolve) => {
-      await window.withProgress(
+    return new Promise<ParsedFrontMatter>((resolve) => {
+      window.withProgress(
         {
           location: ProgressLocation.Notification,
           title: l10n.t(LocalizationKey.commandsI18nTranslateProgressTitle),