-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bangle_setUI_Q3: tweaks (read below) #2571
base: master
Are you sure you want to change the base?
Conversation
- Add custom handlers on top of the standard modes as well. Previously this was only possible for mode == "custom". - The goal here is to make it possible to move all input handling inside `setUI` where today some apps add on extra handlers outside of `setUI` calls. - Change the default behaviour of the hardware button to act immediately on press down. Previously it has been acting on button release. - This makes the interaction slightly snappier. - In addition to the existing `btn` key a new `btnRelease` key can now be specified. `btnRelease` will let you listen to the rising edge of the hardware button.
Thanks! Yes, this looks good. Do you have a Bangle.js 1 to test with? I'd be tempted not to mess with Bangle.js 1 now, but I guess if some apps are using setUI and expecting things to work a certain way then we may have to... |
I don't have a Bangle.js 1 no. Can we just refrain from modifying apps that support Bangle.js 1 (I haven't checked how many are relevant here) and change those over only when/if we get to tweaking the setUI_F18 implementation? And add a note to the reference that the behaviour is slightly different across Bangle.js 1 & 2? |
@gfwilliams if my last comment sounds like it works I can modify this PR to accommodate 🙂 |
I'm not quite sure what you mean here. I feel like a lot of the 'core' apps target both, so we can't just update for one and not the other. So I guess something like So I think some of those apps will need changes, and then they will at least need testing on a Bangle.js 1 |
Yes, so those would fall under "apps that support Bangle.js 1" in my thinking, and should not be modified yet.
EDIT: With
Hm - I seem to not have stumbled upon that specific combo in my daily driving of As for the
Yes, lets hold off for a while then! I'll comment here again if I reach the conclusion that the problems would actually not occur. EDITS: per above |
Edited to correct my writing above.... |
If they don't need modifying to work with this then great - but I think obviously if they end up breaking then I don't think we have a choice. Great news on messagesgui - I guess that uses About the |
setUI
where today some apps add on extra handlers outside ofsetUI
calls.btn
key a newbtnRelease
key can now be specified.btnRelease
will let you listen to the rising edge of the hardware button.These are the same changes introduced as customized setui via espruino/BangleApps#3487, espruino/BangleApps#3491 and espruino/BangleApps#3563.
Forum thread: https://forum.espruino.com/conversations/397606/
Before merge: