Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks on the GPU #4764

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix memory leaks on the GPU #4764

merged 2 commits into from
Aug 4, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jul 27, 2023

Description of changes:

  • remove two P3M global variables (partial fix for Remove global variables #2628)
  • add missing cudaFree to fix all remaining memory leaks on the GPU
  • add a new pypresso option --cuda-sanitizer to run the NVIDIA Compute Sanitizer suite
    • by default, runs memcheck, but one can select another tool via command line options
    • the stand-alone tool cuda-memcheck is deprecated in CUDA 12.0

@jngrad jngrad added this to the ESPResSo 4.3.0 milestone Jul 27, 2023
@jngrad jngrad added the automerge Merge with kodiak label Aug 4, 2023
@kodiakhq kodiakhq bot merged commit f1f64c8 into espressomd:python Aug 4, 2023
5 checks passed
@jngrad jngrad deleted the gpu-memcheck branch August 4, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

@RudolfWeeber RudolfWeeber Awaiting requested review from RudolfWeeber

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Improvement
Projects
None yet
Milestone
ESPResSo 4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @reinaual