Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove performance regression in LB particle coupling #4757

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Remove performance regression in LB particle coupling #4757

merged 1 commit into from
Jul 19, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jul 18, 2023 •
edited
Loading

Fixes #4752

Description of changes:

  • skip expensive runtime checks on type-erased waLBerla fields during particle coupling

@jngrad jngrad requested a review from RudolfWeeber July 18, 2023 15:16
@jngrad jngrad added the automerge Merge with kodiak label Jul 19, 2023
@kodiakhq kodiakhq bot merged commit 95d47b9 into espressomd:python Jul 19, 2023
5 checks passed
@jngrad jngrad deleted the fix-4752 branch July 19, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LB particle coupling: performance drag due to exceptions
2 participants
@jngrad @RudolfWeeber