fix(dcd_dwc2): Reset opened EP counters on bus_reset event #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-jam
force-pushed
the
fix/dcd_dwc2_reset_open_ep_counters
branch
from
594b7a4 to
c37fedb
Compare
peter-marcisovsky
approved these changes
Apr 15, 2024
|
@peter-marcisovsky, Thanks for the prompt review. |
tore-espressif
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
@roma-jam LGTM.
Have you managed to reproduce the error and confirm that it is fixed now?
|
Sure, I reproduced and verified that it was fixed. |
roma-jam
force-pushed
the
fix/dcd_dwc2_reset_open_ep_counters
branch
from
6ab6e79 to
bdcd31a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
bus_resetevent.Additional context
Without resetting the values, during re-connection to the Virtual Machine the counters will be overflowed during the next interface creation on device enumeration.
During the reconnection to the Virtual Machine, the USB bus reset requested several times.
During this event we need to reset the counters for IN/OUT opened EPs, which was added in #20
Close espressif/esp-usb#28