Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp-usb: Add codespell pre-commit hook #8

Merged
merged 3 commits into from
Feb 6, 2024
Merged

esp-usb: Add codespell pre-commit hook #8

merged 3 commits into from
Feb 6, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Feb 1, 2024 •
edited
Loading

Change description

  • Added a codespell pre-commit hook (for all files in project, with codespell-ignore-list)
  • Applied codespell on all files

@roma-jam roma-jam self-assigned this Feb 1, 2024
@roma-jam roma-jam marked this pull request as ready for review February 1, 2024 16:54
tore-espressif
tore-espressif reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @roma-jam !

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Dazza0
Dazza0 approved these changes Feb 2, 2024
View reviewed changes
Copy link

@Dazza0 Dazza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roma-jam Thanks for the addition. LGTM

@tore-espressif tore-espressif merged commit 29a3b52 into master Feb 6, 2024
10 checks passed
@tore-espressif tore-espressif mentioned this pull request Feb 7, 2024
Merged
@tore-espressif
Copy link
Collaborator

@roma-jam We forgot to add the pre-commit to CI, follow-up here #12

@roma-jam roma-jam deleted the feature/add_codespell_precommit_hook branch February 13, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

@Dazza0 Dazza0 Dazza0 approved these changes

@peter-marcisovsky peter-marcisovsky Awaiting requested review from peter-marcisovsky

Assignees

@roma-jam roma-jam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roma-jam @tore-espressif @Dazza0