esp_tinyusb: Removed MIN() definition if defined for cdc_acm #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tore-espressif
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
@roma-jam are there any outstanding issues or can we merge?
|
@tore-espressif not for now. There will be changes in esp_tinyusb test, but if there is something urgent that requires changes in that pr - can be merged. UPD: Nope, the EP size for MSC class in default configuration descriptor wasn't changed. Will do that. |
roma-jam
force-pushed
the
fix/esp_tinyusb_cdc_min_warn
branch
from
94b7dd2 to
f9c6982
Compare
roma-jam
force-pushed
the
fix/esp_tinyusb_cdc_min_warn
branch
from
f9c6982 to
0682387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp_tinyusb v1.4.4
NOT A RELEASE
Change description