Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdc): fix compilation with GCC14 (IEC-153) #59

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

Lapshin
Copy link
Contributor

@Lapshin Lapshin commented Aug 15, 2024

@tore-espressif , sorry for bothering again. I was able to build test app locally because of bug IDF-10801.

To make pipeline pass for gcc14 this change is required

@github-actions github-actions bot changed the title feat(cdc): fix compilation with GCC14 feat(cdc): fix compilation with GCC14 (IEC-153) Aug 15, 2024
@Lapshin
Copy link
Contributor Author

Lapshin commented Aug 23, 2024

@tore-espressif , ping

@tore-espressif
Copy link
Collaborator

@Lapshin is this a final fix? or can we expect any more changes soon?

@Lapshin
Copy link
Contributor Author

Lapshin commented Aug 25, 2024

@Lapshin is this a final fix? or can we expect any more changes soon?

@tore-espressif , this is the final fix for building test applications for our CI.

In case tests fail in runtime I will disable testing and create tickets for you to resolve it.

It would be helpful if you could find out why customized compile options are used here.

@tore-espressif tore-espressif merged commit e4817e2 into espressif:master Aug 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants