feat(cdc): fix compilation with GCC14 (IEC-138) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that you probably also need to bump the component version ( ) so that the changes are released. |
github-actions
bot
changed the title
Lapshin
force-pushed
the
fix_gcc14_errors
branch
from
5c9b666 to
7d80b23
Compare
tore-espressif
approved these changes
Jul 31, 2024
|
Thanks for the update @Lapshin ! I'll merge as is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to gcc14 i faced this issue: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116070
There is a solution to suppress the errors, but I don't know if you happy with these changes and why the default gnu++XX standard derived from idf could not be used...
P.s.: This change looks valid to me if take into account: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116071#c2