Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp_modem_usb_dte): add esp32p4 support & add cat.4 ec20 modem #42

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

tore-espressif
Copy link
Collaborator

Closes #30

@tore-espressif tore-espressif self-assigned this Jun 17, 2024
@tore-espressif
Copy link
Collaborator Author

@leeebo I cherry picked your commit from #30 and added a 'known issue' section. We can merge ASAP so we don't block any esp_modem examples updates

@leeebo
Copy link
Collaborator

leeebo commented Jun 17, 2024

@tore-espressif Sorry for leaving PR #30 so long, because when I tried to do iperf test (PC->ETH->USB->4G), I encountered some problems (Ping was normal, but TCP communication could not be established when I visited the web page), and I haven't confirmed the root cause of the problem ( NAPT? Or maybe because of P4 Cache?) But most likely 'esp_modem_usb_dte' is unrelated, so I think yes this PR can be merged first

@leeebo leeebo self-requested a review June 17, 2024 07:25
Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tore-espressif tore-espressif merged commit 6286d4f into master Jun 17, 2024
17 checks passed
@tore-espressif tore-espressif deleted the feature/modem_p4 branch June 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants