-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UVC driver release 1.0.4 (IEC-104) #31
UVC driver release 1.0.4 (IEC-104) #31
Conversation
related: espressif/libuvc#1 |
@lijunru-hub LGTM! but please add more detailed PR descriptions (eg. the purpose, and specs you referred). and please add the scope information in your commit message eg. |
"USB Video Payload Frame Based v1.5" https://www.usb.org/document-library/video-class-v15-document-set |
@lijunru-hub PTAL at the pedantic compiler errors https://github.com/espressif/esp-usb/actions/runs/8795816894/job/24148662774?pr=31#step:4:10619 |
e1d112c
to
c0f4575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lijunru-hub Thanks for the request!
This suppose to be a release for verison 1.0.4 of uvc host class driver.
Could you please update the PR description accordingly? (you can refer to #24 or #11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
Changes LGTM.
@tore-espressif PTAL |
@tore-espressif @roma-jam |
c0f4575
to
a2b5ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I rebased the PR and we can merge after the CI succeeds
// Copy to local buffer due to potential misalignment issues. | ||
uint32_t raw_desc[25]; | ||
uint32_t desc_size = ((const vs_frame_desc_t *)buff)->bLength; | ||
memcpy(raw_desc, buff, desc_size); |
Check warning
Code scanning / clang-tidy
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning
format frame based
descriptorframe frame based
descriptor