Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add copyright license check #15

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Feb 12, 2024

Added copyright header check to pre-commit

@tore-espressif tore-espressif self-assigned this Feb 12, 2024
@tore-espressif tore-espressif force-pushed the feat/ci_add_copyright_check branch from e987e80 to 705e4b8 Compare February 13, 2024 08:43
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should we added the changes also to a git workflow?

Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking whether you need to update the years on the license if you are changing the license itself, not the actual code.

Found you it's ok the way as it is now. But, correct me if I am wrong.
Otherwise, LGTM.

@tore-espressif
Copy link
Collaborator Author

Thanks for the reviews!

@roma-jam what do you mean by

Should we added the changes also to a git workflow?

If you have pre-commit installed the check will run automatically, so there is no need to do anything extra

@roma-jam
Copy link
Collaborator

@tore-espressif The same as you did here: #12?

@tore-espressif
Copy link
Collaborator Author

#12 added pre-commit run to CI.

So this change will be automatically reflected in your local repo and also checked in CI

@tore-espressif tore-espressif merged commit a0eae4d into master Feb 13, 2024
11 checks passed
@tore-espressif tore-espressif deleted the feat/ci_add_copyright_check branch February 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants