fix(cdc_acm): Fix closing of already closed device #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tore-espressif
force-pushed
the
feature/cdc_func_descriptors
branch
from
81f731f to
1caec88
Compare
roma-jam
approved these changes
Feb 7, 2024
|
@roma-jam Thank you for the review!
I rebased feature/cdc_func_descriptors on master so that is why you see 2 commits. I'll fix before merging |
tore-espressif
force-pushed
the
feature/cdc_func_descriptors
branch
from
1caec88 to
f950437
Compare
tore-espressif
force-pushed
the
fix/cdc_acm_close
branch
from
7ec1e2f to
ea6f78e
Compare
tore-espressif
force-pushed
the
fix/cdc_acm_close
branch
from
ea6f78e to
c267a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found out during esp-serial-flasher CDC operation.
In case the user does not track status of the CDC device and attempts to close the device from multiple places/threads the driver would crash
cc @DNedic