-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ncm): Changed NTB default value to fix DRAM overflow on esp32s2 #125
Conversation
212e73f
to
e4e5fcf
Compare
@roma-jam @peter-marcisovsky It seems we were kind of hasty when we set the default NCM buffer sizes... From my tests, 3 buffers and 3200 size perform well. This allocates 19kB (out of 320kB on S2) compared to current 48kB. |
@tore-espressif I am on it. @peter-marcisovsky |
The @roma-jam reffer to the MR description with the table about RAM vs Performance. |
@peter-marcisovsky Thanks, anyway that is a good time to add the Also, the DRAM could vary between the releases and any changes in DRAM, occupied by other parts could lead to overflow. I think, that 10% free remaining ram is enough. @tore-espressif WDYT? 10%? 15%? 20%? |
e4e5fcf
to
4c4de68
Compare
@tore-espressif nevermind, I checked the remaining DRAM for all releases, and with 3/3 X 3200 it always > 10%. I think that is enough memory for other modules to manipulate. |
4c4de68
to
a25e028
Compare
@tore-espressif UPD: latest master, esp32s3, 3/3 X 3200, DMA mode And nothing in the debug regarding the errors and/or warnings... :( |
@roma-jam if you are trying to catch the To be able to see it, I had to change the verbosity level for this message specifically in |
@peter-marcisovsky I was aimed for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please don't forget to add release note in the release PR
@tore-espressif Already there: #126 |
Requirements
Default value for NCM NTB buffers were 3/3 of 8192 bytes, which led to DRAM overflow on ESP32S2 during the esp-idf sta2eth example build.
Amount of memory, that could be used to hold NTB does depend on the application logic.
Description
This is a 2/3 PR to fix the problem.
To enable the build of the Network example, default value of the buffers amount for transmission and reception side were changed to 1.
Memory Usage for ESP32S2
Comparison values for
examples/network/sta2eth
to select the optimal buffer size and count.PR plan:
Related
Testing
N/A
Checklist
Before submitting a Pull Request, please ensure the following: