refactor(config_test): Added the test_app for various configurations (part 2/2) #111
Conversation
roma-jam
changed the title
roma-jam
force-pushed
the
feature/dconn_detection_test
branch
from
0726ee3 to
db62192
Compare
roma-jam
force-pushed
the
refactor/add_config_test
branch
from
c6d9052 to
73ea243
Compare
roma-jam
force-pushed
the
refactor/add_config_test
branch
3 times, most recently
from
de1a18b to
3345b90
Compare
device/esp_tinyusb/test_apps/configuration_desc/main/test_config_desc.c
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/configuration_desc/main/test_config_desc.c
Outdated
Show resolved
Hide resolved
roma-jam
force-pushed
the
refactor/add_config_test
branch
from
1bba7a2 to
2ed1169
Compare
| * - HS configuration descriptor is not provided by user (legacy compatibility) and default HS config descriptor is using when possible. | ||
| * - Qualifier descriptor. | ||
| */ | ||
| TEST_CASE("descriptors_config_device_and_config", "[esp_tinyusb][usb_device][config]") |
There was a problem hiding this comment.
This test fails on S3 and Win10 host. Could you please double check?
There was a problem hiding this comment.
This is really strange.
Can you describe exactly please, how it fails?
| __test_tinyusb_set_config(&tusb_cfg); | ||
| } | ||
|
|
||
| #if (TUD_OPT_HIGH_SPEED) |
There was a problem hiding this comment.
For future: We will run this test on P4 for both FS and HS configurations, so we might have to update this #ifdefs
There was a problem hiding this comment.
Anyway, I will need to update this test during the run-time configuration.
Maybe after run-time will be available, we can provide an error for unsupported configurations.
There was a problem hiding this comment.
In that case, maybe it is not that important to add these tests right now.
@tore-espressif, WDYT about moving them to the release, when we will add run-time configuration?
Does it make sense to you?
roma-jam
force-pushed
the
refactor/add_config_test
branch
from
2ed1169 to
1bd6261
Compare
Description
Split the test application for cdc and disconnection verification.
Part2/2: Added the test_app for tinyusb various configurations
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: