esp_tinyusb: Adding bvalid_signal test #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-jam
force-pushed
the
feature/esp_tinyusb_bvalid_signal_test
branch
from
fab7d9f to
95b3ee9
Compare
roma-jam
changed the title
roma-jam
force-pushed
the
feature/esp_tinyusb_bvalid_signal_test
branch
from
95b3ee9 to
0da1e0d
Compare
tore-espressif
requested changes
Feb 6, 2024
There was a problem hiding this comment.
@roma-jam Thank for the test! Could you please add another test that would the same as bvalid_signal but with ongoing transfers?
Also please consider renaming to sudden disconnection... :)
roma-jam
force-pushed
the
feature/esp_tinyusb_bvalid_signal_test
branch
2 times, most recently
from
91da76e to
5dede2c
Compare
roma-jam
changed the title
Dazza0
reviewed
Feb 8, 2024
tore-espressif
approved these changes
Feb 8, 2024
roma-jam
force-pushed
the
feature/esp_tinyusb_bvalid_signal_test
branch
from
5dede2c to
1325870
Compare
roma-jam
force-pushed
the
feature/esp_tinyusb_bvalid_signal_test
branch
from
1325870 to
d0b5b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp_tinyusb v1.4.4
NOT A RELEASE
Change description
bvalid_signalverification.Details
USB Device events, such as attach (plug) and detach (unplug) are detected via
bvalid_signal, which can be connected to any (*mostly) external PIN. (In the most common cases, this external PIN connected to VBUS USB via resistor divider to detect the VBUS power presence. For reference, check Self-Powered Device)When USB Device (self-powered) is attached to the USB Host, the VBUS becomes High.
When USB Device (self-powered) is detached from the USB Host, the VBUS becomes Low.
Both of attach and detach, trigger the dcd_dwc2 layer interrupt with
DCD_EVENT_UNPLUGGEDevent.Current test implement the USB Device without any interface and connect the
bvalid_signalto the High or Low signal source to emulate the VBUS presence/absence.For smoke testing, 10 iterates is enough to see that logic is working.
For load testing, please, change the parameter
DEVICE_DETACH_TEST_ROUNDSintest_bvalid_sig.c.Important notice
Without changes in espressif/tinyusb#19 the test doesn't work.