Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_tls): prevent freeing global CA store after each request (IDFGH-4647) #6461

Closed
wants to merge 2 commits into from

Conversation

SiarheiVolkau
Copy link
Contributor

Identical PR for ESP8266 espressif/ESP8266_RTOS_SDK#1037
Not tested on ESP32.

@github-actions github-actions bot changed the title fix(esp_tls): prevent freeing global CA store after each request fix(esp_tls): prevent freeing global CA store after each request (IDFGH-4647) Jan 25, 2021
@AdityaHPatwardhan
Copy link
Collaborator

@SiarheiVolkau , sorry for the late turnaround
We had internal discussions about this. The thing is esp_tls is a high level wrapper around mbedtls and wolfssl. So it is not appropriate to use esp_tls API in mbedtls. ( My bad, I should have mentioned this at the time of the reviewing this PR). Hence this PR can no longer be accepted.
I have fixed this issue with a different approach and appropriate MR has been raised in our internal code base. It should be merged in a couple of days in our internal codebase and then it will be synced to GitHub repo after some time.
Thank you for bringing our attention to this issue and your contribution in fixing it.

@mahavirj
Copy link
Member

@SiarheiVolkau As mentioned above this is now fixed (with different approach) in bf513b6#diff-267dab0fdb0a487503dba92eb56e659f8889988d82c7608231db43604a5bbd79

Than you for your contribution and patience!

@mahavirj mahavirj closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants