feature(lvgl_port): RGB888 SIMD fill #480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@pborcin thanks for the changes. Nice work with the switch-case implementation. I have never tried that myself (did not have a proper use case) but this looks like a good one.
Sorry for the review comments regarding your style of commenting, but as you might have seen the assembly is very hard be read and to be navigated through and commenting makes it bit easier for us to know what is going on and which buffer are you aligning and where to are you jumping. Thank you.
I will also try the test app and let you know.
components/esp_lvgl_port/test_apps/simd/main/lv_blend/src/lv_draw_sw_blend_to_rgb888.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/lv_blend/src/lv_draw_sw_blend_to_rgb888.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/lv_blend/src/lv_draw_sw_blend_to_rgb888.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/test_lv_fill_benchmark.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/test_lv_fill_functionality.c
Show resolved
Hide resolved
components/esp_lvgl_port/src/lvgl9/simd/lv_color_blend_to_rgb888_esp32s3.S
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/src/lvgl9/simd/lv_color_blend_to_rgb888_esp32s3.S
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/src/lvgl9/simd/lv_color_blend_to_rgb888_esp32s3.S
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/src/lvgl9/simd/lv_color_blend_to_rgb888_esp32s3.S
Show resolved
Hide resolved
pborcin
force-pushed
the
rgb888_accel
branch
2 times, most recently
from
3da85ab to
234966a
Compare
pborcin
force-pushed
the
rgb888_accel
branch
5 times, most recently
from
2d7a665 to
0762ba6
Compare
peter-marcisovsky
requested changes
Jan 30, 2025
components/esp_lvgl_port/test_apps/simd/main/test_lv_fill_functionality.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/test_lv_fill_functionality.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/test_lv_fill_functionality.c
Outdated
Show resolved
Hide resolved
components/esp_lvgl_port/src/lvgl9/simd/lv_color_blend_to_rgb888_esp32.S
Show resolved
Hide resolved
components/esp_lvgl_port/test_apps/simd/main/lv_blend/src/lv_draw_sw_blend_to_rgb888.c
Outdated
Show resolved
Hide resolved
pborcin
force-pushed
the
rgb888_accel
branch
4 times, most recently
from
6958678 to
70a2958
Compare
peter-marcisovsky
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
@pborcin works fine now.
Thank you for the update, nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds SIMD support for LV_DRAW_SW_COLOR_BLEND_TO_RGB888
ESP-BSP Pull Request checklist
Change description
esp32s3SIMD assembly implementation of theRGB888simple fillesp32assembly implementation of theRGB888simple fill